![]() The point being: ! cmd has to be supported for any command (or pipeline) consider: ![]() For instance I rely on expansion of working correctly (ie: evaluating to nothing when there are no args to the function). I confused POSIX with autotools portability on this point, so yeah, it's more about portability to all sh, which isn't so relevant. I checked the posix compliance and it is ok that way. Even if you check the scripts in the portage tree only a couple of them use it as !, everything else is in the form docs state it.Īnyway I guess it is more like a coding habit. Generally in the docs it's said that negating is done as It shouldn't matter, especially when the test expression is a two arguments one. Thanks for the suggestions are right that quoting is better and generally I'm using it but this time I did the replacement a bit lazierĪs for the negation of a test command in an if statement. If you write robustly, you never have to worry about constraints like "we know it's always a particular type of dirname" which might break under prefix, or if the user is trying out something, which makes the script and the project using it more flexible, as well as giving reliability. There's a note in the POSIX sh docs somewhere that ! is preferred. ![]() You can add redundant braces if you want, but they don't stop you needing quoting. One minor flaw I noticed in the initscript change and not sure if it made it to final, but should be fixed on next bump, for robustness is: ![]() The fix is now committed to portage, so just update portage and emerge webmin Meanwhile if you want a quick resolution, you may put the new ebuild and the supporting files in files/ folder in your local overlay and emerge.Ī very quick resolution is to use this service file ( /etc/systemd/system/rvice):Īfter=network.target remote-fs.target nss-lookup.targetĬonditionFileNotEmpty=/etc/webmin/nfĮnvironment="PERLLIB=/usr/libexec/webmin" LANG=īut have in mind that using only this file without the changes in the Webmin's own start/stop/reload/restart scripts in /etc/webmin will result in that the stop/restart command button in the WebGUI of Webmin not work.Īs a side note: the given in the above post ( by Marlo) service file works but is not the correct way to add webmin as systemd service, since Webmin is a forking service that on SIGTERM exits with 1.ĮDIT: Service type changed to simple, because in the rare cases when Webmin's option nofork is enabled, the service type forking will block untill timeout. The new ebuild and changes are under review to be commited to the portage tree. I have taken care of fixing and reporting the systemd integration - The bug report containing an ebuild with systemd support instead of you might want to look in the settings to enable email so you get notifications when people post responses. I'd like to colaborate with this, but i dont know where and how. last i checked systemd and openrc are officially supported init systems. etc/systemd/system/rvice wrote:ĮxecStart=/usr/libexec/webmin/ /etc/webmin/nfĪnd start it with 'systemctl start rvice'Īnd it works, thank you very much for thisįile a bug and include the service state that the service does not ship with the ebuild. i ve already searched over google, and only found this problem mentione in arch forums, service is called rvice. Hello everyone, i have replaced openRC with systemd, and when i install webmin it wont list the asociated service, so i cannot start it. Posted: Thu 4:16 pm Post subject: Webmin and systemd Gentoo Forums Forum Index Unsupported Software Gentoo Forums :: View topic - Webmin and systemd
0 Comments
Leave a Reply. |